Fix broken tests #158
Open
Fix broken tests #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It looks like these tests were added a while back and have been broken for an indeterminate period of time. Since the GitHub workflow was added, this has translated into a bunch of failed actions. - I went ahead and fixed the broken tests. For the most part, it looks like there are missing mocks for the Lock, InboxForActor, and Unlock for each recipient. I made sure that this behavior does indeed exist in the code. - In addition, there was an extra "Host" header added to another test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cjslep,
Please thoroughly review this Pull Request!
Here is the issue related to this PR: #157
I understand Pull Requests without having a corresponding issue will be
automatically rejected.
for an indeterminate period of time. Since the GitHub workflow was
added, this has translated into a bunch of failed actions.
like there are missing mocks for the Lock, InboxForActor, and Unlock for
each recipient. I made sure that this behavior does indeed exist in
the code.